add staticCanMessage method #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 30, 2023 10:14
|
Nice been looking forward to this! Currently not having this is eating up alot of our airstack calls 😆 |
nplasterer
reviewed
Nov 30, 2023
There was a problem hiding this comment.
It appears your missing the place on Client you want to put this static method. Probably here: https://github.com/xmtp/xmtp-react-native/blob/main/src/lib/Client.ts#L120
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt
Outdated
Show resolved
Hide resolved
nplasterer
reviewed
Nov 30, 2023
android/src/main/java/expo/modules/xmtpreactnativesdk/XMTPModule.kt
Outdated
Show resolved
Hide resolved
added 7 commits
November 30, 2023 20:48
|
here the evidence for the new test passed
|
|
This looks really great thanks for all the modifications! I'm just holding off on approving because I want this PR to land first #155 as it makes a lot of formatting changes and I don't want to have any further merge conflicts. 🙏 |
nplasterer
approved these changes
Dec 2, 2023
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes available the
staticCanMessagemethod which is used on the native packages.This change resolves the comment in this discussion